App Submission: Music Assistant#4528
Conversation
al-lac
left a comment
al-lac
left a comment
There was a problem hiding this comment.
Hey @phelipebf,
thanks a lot for contributing the music-assistant app to the Umbrel App Store. 🥇
Really good job on the submission! I added some minor things that need to be adapted.
One issue I still see is that the app is running the UI on Port 8095 which is the one that adguard-home uses. I could not find a way to change this port as of now.
al-lac
added
the
awaiting changes
Co-authored-by: Alexander L. <lackner.alex@gmail.com>
Co-authored-by: Alexander L. <lackner.alex@gmail.com>
Co-authored-by: Alexander L. <lackner.alex@gmail.com>
Co-authored-by: Alexander L. <lackner.alex@gmail.com>
Co-authored-by: Alexander L. <lackner.alex@gmail.com>
Co-authored-by: Alexander L. <lackner.alex@gmail.com>
Co-authored-by: Alexander L. <lackner.alex@gmail.com>
|
Hey @phelipebf, I think I found away around the port clash issue. We could add the following file in the {
"server_id": "ea22c850e3e74462bd24515d860c67bf",
"providers": {
"builtin": {
"values": {},
"type": "music",
"domain": "builtin",
"instance_id": "builtin",
"enabled": true,
"name": "Music Assistant",
"last_error": null
},
"fanarttv": {
"values": {},
"type": "metadata",
"domain": "fanarttv",
"instance_id": "fanarttv",
"enabled": true,
"name": "fanart.tv",
"last_error": null
},
"lrclib": {
"values": {},
"type": "metadata",
"domain": "lrclib",
"instance_id": "lrclib",
"enabled": true,
"name": "LRCLIB",
"last_error": null
},
"musicbrainz": {
"values": {},
"type": "metadata",
"domain": "musicbrainz",
"instance_id": "musicbrainz",
"enabled": true,
"name": "MusicBrainz",
"last_error": null
},
"sendspin": {
"values": {},
"type": "player",
"domain": "sendspin",
"instance_id": "sendspin",
"enabled": true,
"name": "Sendspin",
"last_error": null
},
"theaudiodb": {
"values": {},
"type": "metadata",
"domain": "theaudiodb",
"instance_id": "theaudiodb",
"enabled": true,
"name": "The Audio DB",
"last_error": null
}
},
"core": {
"metadata": {
"values": {
"language": "en_US"
},
"domain": "metadata",
"last_error": null
},
"webserver": {
"values": {
"base_url": "http://umbrel.local:8896",
"bind_port": 8896
},
"domain": "webserver",
"last_error": null
}
}
}Not sure how important the server-id part is for music assistant. |
Sounds good. I will test and commit. |
|
@al-lac I've tested and everything seems good. Follow the updates. |
al-lac
left a comment
al-lac
left a comment
There was a problem hiding this comment.
Hey @phelipebf,
thanks for applying and testing the suggested changes 🔝
I have some minor ones to add, we will already start with creating the gallery assets 🖌️
🎉 Linting finished with no errors or warnings 🎉Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store. Please review the linting results below and make any necessary changes to your submission. Linting Results
Legend
|
|
@al-lac done! |
al-lac
removed
the
awaiting changes
2 participants
App Submission
App name
Music Assistant
Icon
https://www.music-assistant.io/assets/transparent-logo.png
Gallery images
I have tested my app on: